# Contributing to NumPy

Not a coder? Not a problem! NumPy is multi-faceted, and we can use a lot of help. These are all activities we’d like to get help with (they’re all important, so we list them in alphabetical order):

- Code maintenance and development

- Community coordination

- DevOps

- Developing educational content & narrative documentation

- Fundraising

- Marketing

- Project management

- Translating content

- Website design and development

- Writing technical documentation

The rest of this document discusses working on the NumPy code base and documentation. We’re in the process of updating our descriptions of other activities and roles. If you are interested in these other activities, please contact us! You can do this via the numpy-discussion mailing list, or on GitHub (open an issue or comment on a relevant issue). These are our preferred communication channels (open source is open by nature!), however if you prefer to discuss in private first, please reach out to our community coordinators at numpy-team@googlegroups.com or numpy-team.slack.com (send an email to numpy-team@googlegroups.com for an invite the first time).

## Development process - summary

Here’s the short summary, complete TOC links are below:

1. If you are a first-time contributor:

   - Go to https://github.com/numpy/numpy and click the “fork” button to create your own copy of the project.

   - Clone the project to your local computer:

         git clone --recurse-submodules https://github.com/your-username/numpy.git

   - Change the directory:

         cd numpy

   - Add the upstream repository:

         git remote add upstream https://github.com/numpy/numpy.git

   - Now, `git remote -v` will show two remote repositories named:

     - `upstream`, which refers to the `numpy` repository

     - `origin`, which refers to your personal fork

   - Pull the latest changes from upstream, including tags:

         git checkout main
         git pull upstream main --tags

   - Initialize numpy’s submodules:

         git submodule update --init

2. Develop your contribution:

   - Create a branch for the feature you want to work on. Since the branch name will appear in the merge message, use a sensible name such as ‘linspace-speedups’:

         git checkout -b linspace-speedups

   - Commit locally as you progress (`git add` and `git commit`) Use a properly formatted commit message, write tests that fail before your change and pass afterward, run all the tests locally. Be sure to document any changed behavior in docstrings, keeping to the NumPy docstring standard.

3. To submit your contribution:

   - Push your changes back to your fork on GitHub:

         git push origin linspace-speedups

   - Enter your GitHub username and password (repeat contributors or advanced users can remove this step by connecting to GitHub with SSH).

   - Go to GitHub. The new branch will show up with a green Pull Request button. Make sure the title and message are clear, concise, and self- explanatory. Then click the button to submit it.

   - If your commit introduces a new feature or changes functionality, post on the mailing list to explain your changes. For bug fixes, documentation updates, etc., this is generally not necessary, though if you do not get any reaction, do feel free to ask for review.

4. Review process:

   - Reviewers (the other developers and interested community members) will write inline and/or general comments on your Pull Request (PR) to help you improve its implementation, documentation and style. Every single developer working on the project has their code reviewed, and we’ve come to see it as friendly conversation from which we all learn and the overall code quality benefits. Therefore, please don’t let the review discourage you from contributing: its only aim is to improve the quality of project, not to criticize (we are, after all, very grateful for the time you’re donating!). See our Reviewer Guidelines for more information.

   - To update your PR, make your changes on your local repository, commit, run tests, and only if they succeed push to your fork. As soon as those changes are pushed up (to the same branch as before) the PR will update automatically. If you have no idea how to fix the test failures, you may push your changes anyway and ask for help in a PR comment.

   - Various continuous integration (CI) services are triggered after each PR update to build the code, run unit tests, measure code coverage and check coding style of your branch. The CI tests must pass before your PR can be merged. If CI fails, you can find out why by clicking on the “failed” icon (red cross) and inspecting the build and test log. To avoid overuse and waste of this resource, test your work locally before committing.

   - A PR must be approved by at least one core team member before merging. Approval means the core team member has carefully reviewed the changes, and the PR is ready for merging.

5. Document changes

   Beyond changes to a functions docstring and possible description in the general documentation, if your change introduces any user-facing modifications they may need to be mentioned in the release notes. To add your change to the release notes, you need to create a short file with a summary and place it in `doc/release/upcoming_changes`. The file `doc/release/upcoming_changes/README.rst` details the format and filename conventions.

   If your change introduces a deprecation, make sure to discuss this first on GitHub or the mailing list first. If agreement on the deprecation is reached, follow NEP 23 deprecation policy to add the deprecation.

6. Cross referencing issues

   If the PR relates to any issues, you can add the text `xref gh-xxxx` where `xxxx` is the number of the issue to github comments. Likewise, if the PR solves an issue, replace the `xref` with `closes`, `fixes` or any of the other flavors github accepts.

   In the source code, be sure to preface any issue or PR reference with `gh-xxxx`.

For a more detailed discussion, read on and follow the links at the bottom of this page.

### Divergence between `upstream/main` and your feature branch

If GitHub indicates that the branch of your Pull Request can no longer be merged automatically, you have to incorporate changes that have been made since you started into your branch. Our recommended way to do this is to rebase on main.

### Guidelines

- All code should have tests (see test coverage below for more details).

- All code should be documented.

- No changes are ever committed without review and approval by a core team member. Please ask politely on the PR or on the mailing list if you get no response to your pull request within a week.

### Stylistic Guidelines

- Set up your editor to follow PEP 8 (remove trailing white space, no tabs, etc.). Check code with pyflakes / flake8.

- Use NumPy data types instead of strings (`np.uint8` instead of `"uint8"`).

- Use the following import conventions:

      import numpy as np

- For C code, see NEP 45.

### Test coverage

Pull requests (PRs) that modify code should either have new tests, or modify existing tests to fail before the PR and pass afterwards. You should run the tests before pushing a PR.

Running NumPy’s test suite locally requires some additional packages, such as `pytest` and `hypothesis`. The additional testing dependencies are listed in `test_requirements.txt` in the top-level directory, and can conveniently be installed with:

    $ python -m pip install -r test_requirements.txt

Tests for a module should ideally cover all code in that module, i.e., statement coverage should be at 100%.

To measure the test coverage, run:

    $ spin test --coverage

This will create a report in `html` format at `build/coverage`, which can be viewed with your browser, e.g.:

    $ firefox build/coverage/index.html

### Building docs

To build the HTML documentation, use:

    spin docs

You can also run `make` from the `doc` directory. `make help` lists all targets.

To get the appropriate dependencies and other requirements, see Building the NumPy API and reference docs.

#### Fixing Warnings

- “citation not found: R###” There is probably an underscore after a reference in the first line of a docstring (e.g. [1]_). Use this method to find the source file: $ cd doc/build; grep -rin R####

- “Duplicate citation R###, other instance in…”” There is probably a [2] without a [1] in one of the docstrings

## Development process - details

The rest of the story

- Git Basics
  - Install git
  - Get the local copy of the code
  - Updating the code
  - Setting up git for NumPy development
  - Git configuration
  - Two and three dots in difference specs
  - Additional Git resources
- Setting up and using your development environment
  - Recommended development setup
  - Using virtual environments
  - Testing builds
  - Other build options
  - Running tests
  - Running Linting
  - Rebuilding & cleaning the workspace
  - Debugging
  - Understanding the code & getting started
- Building the NumPy API and reference docs
  - Development environments
  - Prerequisites
  - Instructions
- Development workflow
  - Basic workflow
  - Additional things you might want to do
- Advanced debugging tools
  - Finding C errors with additional tooling
- Reviewer guidelines
  - Who can be a reviewer?
  - Communication Guidelines
  - Reviewer Checklist
  - Standard replies for reviewing
- NumPy benchmarks
  - Usage
  - Benchmarking versions
  - Writing benchmarks
- NumPy C style guide
- For downstream package authors
  - Understanding NumPy’s versioning and API/ABI stability
  - Testing against the NumPy main branch or pre-releases
  - Adding a dependency on NumPy
- Releasing a version
  - How to prepare a release
  - Step-by-step directions
  - Branch walkthrough
- NumPy governance
  - NumPy project governance and decision-making
- How to contribute to the NumPy documentation
  - Documentation team meetings
  - What’s needed
  - Contributing fixes
  - Contributing new pages
  - Contributing indirectly
  - Documentation style
  - Documentation reading

NumPy-specific workflow is in numpy-development-workflow.